virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
331 stars 102 forks source link

Backups: Servers to save new select #609

Open iliajie opened 1 year ago

iliajie commented 1 year ago

Jamie, I would like to suggest to revert the change for showing double multi-selects for choosing virtual servers to backup. It just looks much more confusing then the old single multi-select!

Before:

image

Now:

image
jcameron commented 1 year ago

The old one didn't work well for huge lists of domains though - it was basically impossible to see which ones were selected.

iliajie commented 1 year ago

We could use Select2 multi select type?

jcameron commented 1 year ago

What does that look like?

iliajie commented 1 year ago

Like this, e.g.:

image
jcameron commented 1 year ago

Oh that looks nice ... is that something browsers support natively though?

iliajie commented 1 year ago

No, browser's don't support it natively (yet).

I can make it work this way for Authentic theme then .. okay .. ?

jcameron commented 1 year ago

Sure, that would be cool! As long as ui_multi_select behaves exactly the same to CGI scripts.

iliajie commented 1 year ago

I'm not inclined (at the moment) to change ui_multi_select in UI lib, as it has quite a lot of different application cases. I was thinking to do some magic in UI and just to make it work this way specifically for Backup Virtual Server page, and maybe for a few other pages. But I will have a deeper look as I finish working on Virtualmin improvements I mentioned in the chat...

jcameron commented 1 year ago

Oh no, definitely don't do that kind of magic! If we want a different kind of UI for selecting domains, it should be implemented as a new function ..

iliajie commented 1 year ago

Oh, making a new function would work. I will do that!

marclaporte commented 1 year ago

FYI, Tiki is a happy user of Select2 https://doc.tiki.org/Select2