search

virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
320 stars 102 forks source link

Unable to Update Virtualmin Module from “Update modules” tab of “Upgrade Webmin” #641

Closed MSSEsq closed 1 year ago

MSSEsq commented 1 year ago

Webmin does not detect the availability of the updated 7.8.2 version of Virtualmin for display on the Dashboard. Trying to upgrade the Virtualmin module from the “Update modules” tab of the “Upgrade Webmin” page in “Webmin Configuration,” either with the default Update from www.webmin.com radio button selected, or the “Update from other sources…” radio button selected and either http://download.webmin.com/download/virtualmin/virtual-server-7.8.2.gpl.wbm.gz or https://software.virtualmin.com/vm/7/gpl/wbm/virtual-server-7.8.2.gpl-1.wbm.gz entered into the text box, returns “Updating Webmin modules … No Webmin updates for this version.” Virtualmin was originally installed from https://software.virtualmin.com/vm/7/gpl/wbm/virtual-server-7.7.gpl-3.wbm.gz using the “Install Module” page.

It seems possible that the switch to semantic versioning underlies the inability to detect that a version update of a module is available. There is currently no way to use Webmin to update modules. The only current alternatives are to either reinstall modules or obtain updated standard modules as part of a Webmin update.

Webmin version 2.102
 Authentic theme version 21.06
 Kernel and CPU FreeBSD 13.2-RELEASE-p3 on amd64 
Virtualmin version 7.7

jcameron commented 1 year ago

How did you install Virtualmin originally? Was it using our script, or did you just install the module .wbm.gz file directly?

MSSEsq commented 1 year ago

How did you install Virtualmin originally? Was it using our script, or did you just install the module .wbm.gz file directly?

As specified in my initial problem report:

Virtualmin was originally installed from https://software.virtualmin.com/vm/7/gpl/wbm/virtual-server-7.7.gpl-3.wbm.gz using the “Install Module” page.

jcameron commented 1 year ago

Ok I see the bug that causes this - it will be fixed in the next Webmin release.

MSSEsq commented 1 year ago

I replaced the webmin/update.cgi and webmin/webmin-lib.pl files with the versions in commit d8fa7f2 and retested. The results were still the same as described in my original report.

jcameron commented 1 year ago

Actually it looks like we didn't update the version on our side! Try waiting a day for caches to clear and then re-doing the update...

MSSEsq commented 1 year ago

With the webmin/update.cgi and webmin/webmin-lib.pl files having been previously updated with the versions in commit d8fa7f2, and now five days later, further testing produces the same Virtualmin module update failure as originally reported. Since the error message includes “No Webmin updates for this version,” it seems that the failure might be related to the out-of-date https://software.virtualmin.com/vm/7/gpl/wbm/webmin-version file. That file currently was last modified 2022-06-07 06:05 and contains “1.990.” The currently running version of Webmin is 2.102.