Open shoulders opened 8 months ago
Agreed, the TLSA option on the Virtualmin Configuration page should be in Server Templates. That way it controls the defaults for new domains, and the setting on DNS Options controls the current state for one domain.
I referenced this in #696 but thought it might need its own issue
The background
The TLSA option is in the following 2 locations
Virtualmin --> System Settings --> Virtualmin Configuration --> Configuration category: SSL settings --> Create TLSA DNS records for SSL certificates![image](https://github.com/virtualmin/virtualmin-gpl/assets/319997/4110875f-c9b4-4eef-b57c-c13b34a35277)
Virtualmin --> Server Configuration --> DNS Options --> TLSA records enabled?![image](https://github.com/virtualmin/virtualmin-gpl/assets/319997/2a2e19d9-0996-4528-b324-73d49544de6b)
The issue
As you can see there is an option in
Virtualmin Configuration
that says it will enable TLSA for all domains with an SSL and then there is a setting in eachvirtual server (DNS Options)
to enable or disable the TLSA record. There are no settings in the Server templates to control TLSA.The
Virtualmin Configuration
setting is trying to behave like aServer Template
option but instead of this option being configurable per domain, when this setting is changed, all domains will have this setting changed.Enabling TLSA is a per domain/virtual server option rather than a global Virtualmin configuration options.
Proposed Solution
Moved the
Virtualmin Configuration
option into theServer Templates
which is better fit for a per domain configurable option.