virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
308 stars 95 forks source link

Two non-related locations to set TLSA- Needs to be moved to server templates #701

Open shoulders opened 8 months ago

shoulders commented 8 months ago
SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.3
Webmin version 2.105
Usermin version 2.005
Virtualmin version 7.8.2  
Theme version 21.09.5
Package updates 12 package updates are available

I referenced this in #696 but thought it might need its own issue

The background

The TLSA option is in the following 2 locations

The issue

As you can see there is an option in Virtualmin Configuration that says it will enable TLSA for all domains with an SSL and then there is a setting in each virtual server (DNS Options) to enable or disable the TLSA record. There are no settings in the Server templates to control TLSA.

The Virtualmin Configuration setting is trying to behave like a Server Template option but instead of this option being configurable per domain, when this setting is changed, all domains will have this setting changed.

Enabling TLSA is a per domain/virtual server option rather than a global Virtualmin configuration options.

Proposed Solution

Moved the Virtualmin Configuration option into the Server Templates which is better fit for a per domain configurable option.

jcameron commented 8 months ago

Agreed, the TLSA option on the Virtualmin Configuration page should be in Server Templates. That way it controls the defaults for new domains, and the setting on DNS Options controls the current state for one domain.