virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
331 stars 102 forks source link

feature: Have a simple option to disable enable SSH for an account owner #703

Open shoulders opened 11 months ago

shoulders commented 11 months ago
SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.3
Webmin version 2.105
Usermin version 2.005
Virtualmin version 7.8.2  
Theme version 21.09.5
Package updates 12 package updates are available

The issue

There is no simple way to enable/disable SSH access for account owners.

you can use Virtualmin --> System Customization -->custom shells to set things globally

Why

most amatuer hosters will just want SSH off for everyone and they need an easy way to set this. I am from the windows world so the custom shells is far beyond me but I know I should turn SSH of for most of my accounts, they dont need it.

The proposed solution

iliajie commented 11 months ago

Hello,

This is a good suggestion. As I'm working now on improving Edit Users page, so I don't mind adding a drop-down for having control over virtual server administrator user shell.

jcameron commented 11 months ago

You can already configure the domain owner's shell at Manage Virtual Server -> Server Owner Limits -> Other restrictions -> Allowed login type.

shoulders commented 11 months ago

I cant, the permissions are hardcoded. Also this initial setting should be settable in the server template.

image

Virtualmin --> Administration Options --> Edit Owner Limits --> Other restrictions

jcameron commented 11 months ago

You may need to designate another shell as usable by domain admins at System Customization -> Custom Shells.

Also, you can designate a default shell in the server templates, on the Administration user page.

shoulders commented 11 months ago

You may need to designate another shell as usable by domain admins at System Customization -> Custom Shells. Also, you can designate a default shell in the server templates, on the Administration user page.

As an end user, I have no idea what these settings mean, hence the on/off button :smile:.

iliajie commented 11 months ago

As an end user, I have no idea what these settings mean, hence the on/off button 😄.

Yes, I agree, it isn't simple to grasp for the normal users. We may change this though for master administrator to be able to create SSH users. I'm working on improving Edit Users page, which should address this issue as well.

jcameron commented 11 months ago

One easy improvement we could make would be to add a no-SSH shell as one of the default options for the domain admin user.