server template - http2 does not have an inherit option - Githubissues

virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin

https://www.virtualmin.com

GNU General Public License v3.0

319 stars 99 forks source link

server template - http2 does not have an inherit option #710

Open shoulders opened 10 months ago

shoulders commented 10 months ago

SYSTEM INFORMATION
OS type and version	Ubuntu Linux 22.04.3
Webmin version	2.105
Usermin version	2.005
Virtualmin version	7.8.2
Theme version	21.09.5
Package updates	19 package updates are available

The Background

The http2 option is available in the following places:

virtualmin --> system settings --> server templates --> Default Settings --> Edit template section: Website for domain
virtualmin --> system settings --> server templates --> Other Templates --> Edit template section: Website for domain
Virtualmin --> Server Configuration --> Website Options

The issue

the http2 option in all of the 3 areas are the same (default/Yes/No) and this cannot be correct.
in the default settings there should only be on/off there is no need for for default as this option should be binary.
In custom server templates there is no in inheritance option and the default option is present.

The proposed solution

I would recommend the following arrangement

virtualmin --> system settings --> server templates --> Default Settings --> Edit template section: Website for domain
virtualmin --> system settings --> server templates --> Other Templates --> Edit template section: Website for domain
Virtualmin --> Server Configuration --> Website Options

jcameron commented 10 months ago

Actually I think it's correct - the "Default" option means to follow the webserver's default, which may depend on the Apache or Nginx version. But I should re-label those options to make this clearer, and also add an "inherit" option in the non-default template.