virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
313 stars 97 forks source link

change-licence listed twice in virtualmin CLI #793

Open shoulders opened 4 months ago

shoulders commented 4 months ago
SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.4
Webmin version 2.111
Usermin version 2.010
Virtualmin version 7.10.0 Β 
Theme version 21.10
Package updates All installed packages are up to date

The following comand is listed twice when you run the terminal command virtualmin or virtualmin help.

I know this is a small thing. πŸ˜„

change-licence Change a system's Virtualmin license key

image

iliajie commented 4 months ago

Looks like we're diving into the "license" vs. "licence" debateβ€”let the spelling battle begin!

shoulders commented 4 months ago

I did not even notice they were spelt different. πŸ˜„

https://en.wikipedia.org/wiki/Open-source_license

= License 😸

iliajie commented 4 months ago

There are several words with different spellings between American and British English, such as "Practice" (US) vs "Practise" (UK), "Defense" (US) vs "Defence" (UK), "Analyze" (US) vs "Analyse" (UK), and "Color" (US) vs "Colour" (UK), among others.

Addressing this issue in a sensible way is challenging. Personally, I would favor US spelling because it is more commonly recognized globally, often shorter, and simpler. I believe it's not practical to support both.

shoulders commented 4 months ago

However you spell color/colour use that language format. Which I am guessing is US.

I am biased because I am here in Blighty (a.k.a UK)

Being British I am use to the dodgy πŸ˜„ USA spellings, but at least it is English.

Also in the html of virtualmin you use data-locale="en-US"

iliajie commented 4 months ago

I am biased because I am here in Blighty (a.k.a UK)

LOL, you see! πŸ˜†

However you spell color/colour use that language format. Which I am guessing is US.

Perhaps, it might be reasonable and fair to favor US spelling since technology has significantly evolved in the US?

shoulders commented 4 months ago

image

Favor vs Favour

iliajie commented 4 months ago

Favor vs Favour

No, "favor" is actually the American spelling. The British spelling is "favour." πŸ˜…

jcameron commented 4 months ago

Coming back to the original bug, I think we should only list one of the two spellings in the help output..

iliajie commented 4 months ago

I think we should only list one of the two spellings in the help output

+1.