Change the default `System monitors` to something better

virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin

https://www.virtualmin.com

GNU General Public License v3.0

320 stars 101 forks source link

Change the default `System monitors` to something better #867

Open shoulders opened 3 months ago

shoulders commented 3 months ago

SYSTEM INFORMATION
OS type and version	Ubuntu Linux 22.04.4
Webmin version	2.111
Usermin version	2.010
Virtualmin version	7.20.2
Theme version	21.10
Package updates	All installed packages are up to date

the issue

When you install virtualmin you get a default set of monitors that are inherited from webmin which do not refelct Virtualmin's purpose.

proposed solution

These are more in-line with virtualmin as a web hosting platform

additional

I would like to re-arrange the order, but this is not currently possible.
the section webmin is called System and Server Status, does this tally with the widgets name in virtualmin?

iliajie commented 3 months ago

Hello,

When you install virtualmin you get a default set of monitors that are inherited from webmin which do not refelct Virtualmin's purpose.

These are coming from the module itself. It isn't related to Virtualmin.

These are more in-line with virtualmin as a web hosting platform

This is a good suggestion though it would have to be added under Servers Status, which is a feature of Virtualmin itself:

So, I'd suggest adding the missing Fail2Ban and FirewallD status.

shoulders commented 3 months ago

These are coming from the module itself. It isn't related to Virtualmin.

system monitors should be sculpted by the virtualmin if it is present after initial install, it looks better and is more logical

So, I'd suggest adding the missing Fail2Ban and FirewallD status.

definately if keeping both widgets then adding Fail2Ban and FirewallD status is a good thing.

additional

I think the "System monitors" and "Server Status" widget should be combined. I cannot remember if I have done an issue for this?
- They do the same Job, well almost, the restarting service option could be added to system monitors and this can be a configurable option.

iliajie commented 3 months ago

system monitors should be sculpted by the virtualmin if it is present after initial install, it looks better and is more logical

It isn't enabled by default.

definately if keeping both widgets then adding Fail2Ban and FirewallD status is a good thing.

Sure, why not.

shoulders commented 3 months ago

It isn't enabled by default.

Maybe this should be enabled by default by Virtualmin
All the major provider cPanel, Plesk all have service monitor configured from the beginning including restart watchdogs.
Virtualmin installer could configure the System Monitors that are select and enabled
drop the "system Monitorswidget, add service restart icon tosystem monitors` widget which would reduce code and be an improvement for Virtualmin + Webmin

Let me roll another issue for combining the 2 widgets, enabled by default and configuration by Virtualmin installer.