virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
320 stars 102 forks source link

DNSSEC Zone keys are always the same #878

Open shoulders opened 3 months ago

shoulders commented 3 months ago
SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.4
Webmin version 2.111
Usermin version 2.010
Virtualmin version 7.20.2  
Theme version 21.10
Package updates 5 package updates are available

background

I am trying to figure out why I have a chain of trust issue on my primary domain sexample.com, not my system hostname server.example.com.

the issue

I wanted to regenerate my DNS signatures and then upload the new one to my registrar to see if this was the issue so on my example.com domain so I did the following;

I expected this to change the private and public keys etc in DNSSEC zone keys, but the value were exactly the same afterwards

image

proposed solution

add a regenerate button with a warning saying that you will need to make changes upstream at your registrar to prevent your domain being flagg as untrusted etc.... or something simimiliar to that

additional

If I manually add an A record eg ns1.example.com does this trigger the DNSSEC signatures for it to be created?

jcameron commented 3 months ago

This is actually expected behavior - turning DNSSEC off and on again intentionally doesn't re-generate the key, since this would force users to update the records with their registrar. There is a separate button to create a new key though.

shoulders commented 3 months ago

This is actually expected behaviour - turning DNSSEC off and on again intentionally doesn't re-generate the key, since this would force users to update the records with their registrar.

I thought so

There is a separate button to create a new key though.

p.s. I am on authentic theme

jcameron commented 3 months ago

It's at Webmin -> Servers -> BIND DNS Server -> whatever.com -> Setup DNSSEC Key -> Remove Key

shoulders commented 3 months ago

We have 2 options here:

@jcameron What are your thoughts

iliajie commented 3 months ago

Why re-generate the key? It should never be necessary.

shoulders commented 3 months ago

My thoughts

iliajie commented 3 months ago

I think this is a niche feature for Virtualmin to have.

jcameron commented 3 months ago

Yeah I kind of agree with Ilia here, it's a niche feature and also already available to the root user if really really needed.

shoulders commented 3 months ago

Update Help text

If this is a niche feature could the help be updated instead of the buttons.

image

additional

the actual layout of the options on the page are not correctly sorted anymore ie DNS and Sender Policy Framework options should be split into General options, Sender Policy Framework Other Email, DNSSEC

iliajie commented 3 months ago

Thanks, I'll take a look at this later.