virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
330 stars 102 forks source link

The domain alias must be shown on the "DNS Records" page as a normal record #916

Closed iliajie closed 1 month ago

iliajie commented 1 month ago

Hello Jamie!

Since alias domains don’t have their own “DNS Records” page like top-level and sub-servers do, it would make sense to always display the alias DNS records on the “DNS Records” page, without needing to click the “Show all records” button.

jcameron commented 1 month ago

No I don't think so, since the alias domain DNS records are always copied from the target domain

iliajie commented 1 month ago

From a coding standpoint, I get it. But looking at it from a user’s view, it’s pretty confusing. There’s a separate UI page for adding a domain alias. We add it, then head over to the “DNS Records” page to check, but nothing shows up. Then we jump over to Cloudflare and see the DNS record for the alias there. After that, we go back to the Virtualmin UI and realize the record is hidden behind an extra button.

jcameron commented 1 month ago

I think that's still the right option, because we don't want users to have to see or manage alias domain DNS records.

iliajie commented 1 month ago

But when the admin enables the DNS feature for an alias, they can’t see the DNS record, whether the alias or the parent domain is selected. This is confusing. I don’t see why we wouldn’t want the admin to see the DNS record that was created.

jcameron commented 1 month ago

Maybe we could make the DNS Records page visible in read-only mode when the alias domain is selected? That would be pretty simple..

iliajie commented 1 month ago

Maybe we could make the DNS Records page visible in read-only mode when the alias domain is selected? That would be pretty simple..

Yes, that could work. Though, is it difficult to make it clearly visible for the parent domain?

jcameron commented 1 month ago

Yes, I've just implemented this

iliajie commented 1 month ago

Thanks, Jamie! However, the links are still displayed, and it’s still possible to edit the records, e.g.:

image
jcameron commented 1 month ago

Ooops I forgot to commit another patch .. should be done now

iliajie commented 1 month ago

Now it's perfect! Thank you!