virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
330 stars 102 forks source link

Re-Send Signup Email - should be in Account Plans #961

Open shoulders opened 2 weeks ago

shoulders commented 2 weeks ago
SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.5
Usermin version 2.102
Virtualmin version 7.20.2 Pro
Theme version 21.20.7
Apache version 2.4.52
Package updates 49 package updates are available

background

Mail Options --> Re-Send Signup Email

image

issues

Additional

This option is currently doing a live look up from the server templates which is what I am advocating for Account Plan rather than the current legacy system where you push the settings to acccount.

jcameron commented 2 weeks ago

I'm not sure this should be in account plans, as plans control only limits on what virtual server owners can do, like the number of domains or mailboxes they can own.

But I do agree that the menu item should be hidden!

iliajie commented 1 week ago

But I do agree that the menu item should be hidden!

Where exactly is this feature supposed to be enabled in the template?

iliajie commented 1 week ago

Plus, don’t we already have a “Re-Send Signup Email” button when editing the domain owner or mailbox user which is always shown!?

image

This feature is so niche — it doesn’t need its own menu link. I say we scrap it!

shoulders commented 1 week ago

Server templates should be reserved for setting up the virtual server, php versions and settings, does this server have mail etc .

Accounts/plans/features are things the user is allowed to do, quotas and the like.

Both have distinct roles and should be kept this way. 😃

I do note there is one page which I cannot remember it's name that absolutely should not be in server templates. I can post an image later today if needed.

Being allowed to resend a signup email is a user permission thing. Maybe restrict to reseller and admins?

jcameron commented 1 week ago

Plus, don’t we already have a “Re-Send Signup Email” button when editing the domain owner or mailbox user which is always shown!?

That button is for mailboxes, the link in question here is for the domain owner. But I agree that maybe it doesn't need it's own rarely used menu item.

iliajie commented 1 week ago

That button is for mailboxes, the link in question here is for the domain owner.

If you check my screenshot above, you’ll see it’s actually the page for the domain owner.

But I agree that maybe it doesn't need it's own rarely used menu item.

Then let’s remove that page and its link, and conditionally show the button directly on the "Edit User" page?

jcameron commented 1 week ago

Oh right, but for the domain owner it would be sending the email that explains how to login for email, which is a different template than the one for domain creation.

iliajie commented 1 week ago

In this case, maybe we could send two emails from different templates specifically for the domain owner to keep it simpler?

iliajie commented 1 day ago

⬆️

jcameron commented 1 day ago

I think that button should re-send the domain creation email, rather than having a separate link on the left menu

iliajie commented 1 day ago

For domain owner we could send to different emails — creation email and explanations on how to login. Right? And, yes, no extra link needed.