search

vle-forge / vle

Virtual Laboratory Environment
http://www.vle-project.org
GNU General Public License v3.0
21 stars 22 forks source link

win 32 binary for vle #392

Closed rtrepos closed 2 years ago

rtrepos commented 2 years ago
quesnel commented 2 years ago

Thank you for the pull request.

Can you add a prefix to the commit:

update appveyor script -> appveyor:
add qcustomplot -> gvle: + add qcustomplot source code
fix typo -> win32:
echo path -> appveyor:
update cmake path -> appveyor:
update QT5 version -> appveyor: + fix `update`
echo innosetup -> appveyor:
update innosetup path -> appveyor:
remove metalink -> appveyor:
test Qt dll -> appveyor::

Apart from these changes, everything looks good for me.

quesnel commented 2 years ago

Thank you!

rtrepos commented 2 years ago

Salut Goth !

J'avance un peu pour rvle, j'ai compilé expat avec le compilo de rtools.

Mon dernier log de rvle est ici : https://ci.appveyor.com/project/RonanTrpos/rvle

La compile se passe bien mais j'ai un souci au moment du chargement de la lib rvle dans R.

Si jamais t'as une idée pour debugger ca ca m'irait bien.

Je ne sais pas quelle dll bloque..

A +

Ronan

Ronan Trépos

Research engineer INRAE - MIAT

web : https://miat.inrae.fr/site/Ronan_TREPOS

tel : +33(0)5 61 28 51 89

De : Gauthier Quesnel @.***> Envoyé : samedi 18 décembre 2021 08:56 À : vle-forge/vle Cc : Ronan Trepos; Author Objet : Re: [vle-forge/vle] win 32 binary for vle (PR #392)

Thank you for the pull request.

Can you add a prefix to the commit:

update appveyor script -> appveyor: add qcustomplot -> gvle: + add qcustomplot source code fix typo -> win32: echo path -> appveyor: update cmake path -> appveyor: update QT5 version -> appveyor: + fix update echo innosetup -> appveyor: update innosetup path -> appveyor: remove metalink -> appveyor: test Qt dll -> appveyor::

Apart from these changes, everything looks good for me.

- Reply to this email directly, view it on GitHubhttps://github.com/vle-forge/vle/pull/392#issuecomment-997165623, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAN7FJGURLFP63QWLZK6E3URQ5BBANCNFSM5KDDZRYQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>