feat(dimmableLight): 💡 added support for dimmable lights

vlebourl / tahoma_extended

Extend the home assistant tahoma integration with new features not yet published to HA.

MIT License

2 stars 3 forks source link

feat(dimmableLight): 💡 added support for dimmable lights #3

Closed CedricGatay closed 4 years ago

CedricGatay commented 4 years ago

dimmable lights exposed through Tahoma API are now manageable
wink effect at full brightness is implemented
scan interval of 30s
brightness is mapped from percentages to/from 8 bit scale
there is no support for timed on / off as it is better done with an automation in my POV

vlebourl commented 4 years ago

thanks

iMicknl commented 4 years ago

Thanks! I was just looking into building this myself, will try your implementation tomorrow. :)

iMicknl commented 4 years ago

@CedricGatay will you work on merging this change into home assistant core?

CedricGatay commented 4 years ago

I was wondering if it should be done and why the work that @vlebourl did here is not merged ?

iMicknl commented 4 years ago

@cedricgatay I was wondering the same. I guess they still accept changes to the Tahoma component?

vlebourl commented 4 years ago

To be fair, this repo was just for my personal use at first, but I'm happy people are taking interest. Now, as the code does not fit in anyway the standards for submission into home assistant core, I use it as a draft for testing. Some features have been merged into the core, such as the smart lock (removed from release 0.5). But it take quite some time to clean up the code and submit it to HA, so I haven't done it for other features so far...