search

vmware-archive / photon-controller

Photon Controller
Other
26 stars 4 forks source link

Provide disk IO statistics for persistent disks (at least) #57

Open govint opened 7 years ago

govint commented 7 years ago

Photon controller supports persistent-disks and workloads that execute in the VMs - especially containers running apps - need to be able to profile their apps and not have to rely on guest level statistics which surely aren't accurate as what the ESX hosts generate. There needs to be a way to pull stats for a disk via API and also show those on the UI per disk

AlainRoy commented 7 years ago

What kinds of stats are you looking for, exactly? What kind of update frequency do you require? What entity would query the stats? It seems unlikely that an app running in a container/VM would know how to query Photon Controller for stats on a specific disk, so understanding the requirements of that entity would be important. In some cases, we may need to have specific integrations to make it useful. For instance, if Kubernetes can provide stats, we'd need to fit into their framework.

This seems worthy of further discussion. I think the requirements need to be more detailed in order to do something useful.

cc: @giskender

govint commented 7 years ago

What kinds of stats are you looking for, exactly? What kind of update frequency do you require? What entity would query the stats?

These are disk IO performance stats that can be pulled via VIM API today from an ESX host. Those API allow setting an update frequency and allow selecting what counters to fetch for a given device attached to a VM.

It seems unlikely that an app running in a container/VM would know how to query Photon Controller for stats on a specific disk, so understanding the requirements of that entity would be important

We have multiple monitoring tools and performance data aggregators that allow visualizing performance. A user thats using persistent disk for apps has no way to get accurate information or even workload characterization (the way we get stats from the ESX) for their apps. Even if they run in containers IO performance for apps needs to be measurable accurately - else how does the user know what the issue is with their app or storage? How do they know they are getting the performance for the storage profile that they have opted for?

In some cases, we may need to have specific integrations to make it useful. For instance, if Kubernetes can provide stats, we'd need to fit into their framework.

CAdvisor (made this PR some time back - https://github.com/google/cadvisor/pull/1514), Prometheus for example - there are many that should be able to get and use these.

On Mon, Nov 7, 2016 at 12:20 PM, Alain Roy notifications@github.com wrote:

What kinds of stats are you looking for, exactly? What kind of update frequency do you require? What entity would query the stats? It seems unlikely that an app running in a container/VM would know how to query Photon Controller for stats on a specific disk, so understanding the requirements of that entity would be important. In some cases, we may need to have specific integrations to make it useful. For instance, if Kubernetes can provide stats, we'd need to fit into their framework.

This seems worthy of further discussion. I think the requirements need to be more detailed in order to do something useful.

cc: @giskender https://github.com/giskender

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vmware/photon-controller/issues/57#issuecomment-258759626, or mute the thread https://github.com/notifications/unsubscribe-auth/APHseFcJcqRa6gyM7GwUNpuHXpYwehPKks5q7solgaJpZM4Kq4oC .