search

vmware / go-vcloud-director

Golang SDK for VMware Cloud Director
Other
80 stars 76 forks source link

Simplify Test_LDAP #505

Closed dataclouder closed 2 years ago

dataclouder commented 2 years ago

This is similar to the change of TestAccVcdOrgGroup in PR-909

The reason for this change is that what we are testing within TestLDAP is quite fast, but the preparation takes a long time, so much that we added a tag skipLong to avoid such test in given circumstances. Moreover, creating a LDAP server (which requires routing to the VM) would fail for environmental reasons that add nothing to our testing experience. The change requires a pre-set LDAP server, which is created only once per each VCD in a separate –automated– task, thus allowing us to test the intended feature without waiting for the server to be up.

adambarreiro commented 2 years ago

First review, all good imho! I'll run the tests and then approve.