vmware / go-vcloud-director

Golang SDK for VMware Cloud Director
Other
80 stars 76 forks source link

fix(vapp): pointer Features not initialized #555

Closed gaetanars closed 1 year ago

gaetanars commented 1 year ago

Fix nil point dereference in UpdateNetworkAsync function on networkToUpdate.Configuration.Features

IMPORTANT

To help us process your pull request efficiently, please follow the guidelines shown below.

A Pull Request should be associated with an Issue

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs. If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues, and potentially we'll be able to point development in a particular direction.

We accept PRs without associated issues provided the change is sufficiently evident from the commit message. If you have typos or simple bug fixes go for it.

Description

Related issue: #554

vmwclabot commented 1 year ago

@gaetanars, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 1 year ago

@gaetanars, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

adezxc commented 1 year ago

Hello @gaetanars, thank you for the contribution!

Funnily enough, we detected this bug yesterday, so I also implemented this change in #550 and we will proceed with that one, and close this one. Will close #554 when merged aswell.

vmwclabot commented 1 year ago

@gaetanars, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide actual email address