Closed gaetanars closed 1 year ago
@gaetanars, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.
Hello @gaetanars, thank you for the contribution!
Funnily enough, we detected this bug yesterday, so I also implemented this change in #550 and we will proceed with that one, and close this one. Will close #554 when merged aswell.
Fix nil point dereference in UpdateNetworkAsync function on networkToUpdate.Configuration.Features
IMPORTANT
To help us process your pull request efficiently, please follow the guidelines shown below.
A Pull Request should be associated with an Issue
We wish to have discussions in Issues. A single issue may be targeted by multiple PRs. If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues, and potentially we'll be able to point development in a particular direction.
We accept PRs without associated issues provided the change is sufficiently evident from the commit message. If you have typos or simple bug fixes go for it.
Description
Related issue: #554
(Required) Short description of changes in the PR subject
(Required) Detailed description of changes include tests and documentation. If the pull request contains multiple commits with detailed messages, refer to those instead
(Optional) Names of reviewers using @ sign + name