vmware / go-vcloud-director

Golang SDK for VMware Cloud Director
Other
80 stars 79 forks source link

Add support for parsing vmNameInVc xml attribute on QueryResultVMRecordType struct #635

Open mrfoxes opened 8 months ago

mrfoxes commented 8 months ago

Description

Related issue: #634

Edited: closes #634

vmwclabot commented 8 months ago

@mrfoxes, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 8 months ago

@mrfoxes, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 8 months ago

@mrfoxes, VMware has approved your signed contributor license agreement.

Didainius commented 7 months ago

@mrfoxes, could you apply the patch I mentioned in https://gist.github.com/Didainius/d585e99595f6a9537209244778c174b5

It also added a tiny check that the field provides value