Open drnic opened 6 years ago
Thanks a lot @drnic. Your suggestions are really helpful. We will find time to make according improvement. We also welcome any kind of contribution to harbor-boshrelease project.
Hi @drnic, I have cleaned up the manifest files in commit https://github.com/vmware/harbor-boshrelease/commit/089c7c536b7ccb2aee67c54f4aad8f125e077169. Will use the operators approach when adding more deployment manifests.
I appreciate that you've shown many different ways to run Harbor with different manifests. I'm writing to share a pattern that is evolving in other BOSH releases.
In the BOSH community, the consistent pattern we're going with is:
manifests
folder (some older projects have atemplates
folder, butmanifests
is newer and nicer)manifests/operators
folder (some projects havemanifests/ops-files
)manifests/harbor.yml
base manifests that works with zero user-provided variables, e.g. no static IPs or elastic IPs, containsreleases:
that reference final releases or ideally compiled releases, and allows the very simple README instructions:manifests/operators/create.yml
- overrides theharbor
release withversion: create
anduri: .
to make it easy to runbosh deploy manifests/harbor.yml -o manifests/operators/create.yml
to emulatebosh create-release --force && bosh upload-release --rebase && bosh deploy ...
vsphere.yml
etc where you're trying to communicate something specific about the target infrastructure; but this isn't common. In your manifests, the only "vsphere" idea I see is the static IP, rather than an elastic IP for other infrastructures?An example BOSH release project that maintains this pattern is https://github.com/cloudfoundry-community/redis-boshrelease
Thanks for open sourcing the Harbor bosh release!
/cc @cppforlife