search

vmware / network-config-manager

Network configuration manager is utility for easily configuring networking on a linux system
Other
35 stars 10 forks source link

set_ipv6: Adding option to set static addresses and gateway using set… #667

Closed ntsbtz closed 7 months ago

ntsbtz commented 7 months ago

…-ipv6 command.

Issue: Following are the issue related to this command.

Using this command not able to tune accept-ra, dhcp and add static address at once. Setting address with keep no option is also afecting other configuration like dns and ipv4.

Fix: Adding support to tune accept-ra, dhcp and static address at once. Also setting address and gateway always overwrite existing ipv6 addresses and gateway without afecting ipv4 address and gateway.

ssahani commented 7 months ago

This is already implemented by set-network. Your are duplicating the work and it's a deprecated function. ALso can you add tests for each of the use cases.

ssahani commented 7 months ago

Adding option to set > Add option It not a issue rather a enhancement.

ntsbtz commented 7 months ago

Adding option to set > Add option It not a issue rather a enhancement.

Correct thanks for taking it into notice. Will update the commit message.