search

vn-tools / arc_unpacker

CLI tool for extracting images and sounds from visual novels.
GNU General Public License v3.0
562 stars 83 forks source link

Again build on VS. Move CMake to extra. #20

Closed acaly closed 8 years ago

acaly commented 9 years ago

This time with tests. But there're 3 failed, and a stack corruption is reported.

arc_unpacker_test.exe is a Catch v1.1 b3 host application.
Run with -? for options

-------------------------------------------------------------------------------
Decoding DXT5 DDS textures works
-------------------------------------------------------------------------------
D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\microsoft\dds_converter_test.cc(28)
...............................................................................

D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\microsoft\dds_converter_test.cc(28): FAILED:
due to unexpected exception with message:
  boost::filesystem::path codecvt to wstring: error

-------------------------------------------------------------------------------
Decoding DPNG images works
-------------------------------------------------------------------------------
D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\qlie\dpng_converter_test.cc(6)
...............................................................................

D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\qlie\dpng_converter_test.cc(6): FAILED:
due to unexpected exception with message:
  boost::filesystem::path codecvt to wstring: error

-------------------------------------------------------------------------------
Decoding TFCS files works
-------------------------------------------------------------------------------
D:\Documents\Programmes\cpp\arc_unpacker\tests\formats\touhou\tfcs_converter_test.cc(6)
...............................................................................

D:\Documents\Programmes\cpp\arc_unpacker\tests\test_support\converter_support.cc(30): FAILED:
  REQUIRE( expected_file.io.size() == actual_file.io.size() )
with expansion:
  3299 (0xce3) == 3285 (0xcd5)

===============================================================================
test cases:  113 |  110 passed | 3 failed
assertions: 1758 | 1755 passed | 3 failed
acaly commented 9 years ago

Related #18, #19.

acaly commented 9 years ago

Please check it. I'll add information in README later.

rr- commented 9 years ago

What is your file system encoding? The failing tests could indicate a problem separate from VS support.

acaly commented 9 years ago

In fact I'm using Boost Pre-Built Binaries. I'm not sure what encoding it uses. If it's not related to VS support, I don't want to fix it now.

rr- commented 9 years ago

I mean, what is your system locale in Windows? Either way, I'll merge it after you add information to README.

After merging, I might also tweak it a little to support compiling with GNU g++ for people that, for whatever reason, don't want to use waf on GNU/Linux.

acaly commented 9 years ago

I'm using Chinese version of Windows 7. So it's GBK (936).

rr- commented 9 years ago

Can you check if entrypoint.cc resolves to https://github.com/vn-tools/arc_unpacker/blob/master/src/compat/entry_point.h#L11 rather than non-wide main() in both tests and main executable?

acaly commented 9 years ago

Yes, _WIN32 is automatically defined, and it's resolved to wchat_t version.

rr- commented 8 years ago

Closed in https://github.com/vn-tools/arc_unpacker/commit/7dde78b15142cb2cb1db17a3ba3a78098bbf8425 .