Fureraba extraction support

vn-tools / arc_unpacker

CLI tool for extracting images and sounds from visual novels.

GNU General Public License v3.0

573 stars 83 forks source link

Fureraba extraction support #62

Closed ghost closed 8 years ago

ghost commented 8 years ago

Fureraba datas are stored in .arc files. The magic string starts with Buriko which shows this is linked to the existing bgi/arc decoder. Their extraction is quite similar but the header is larger. I added an ArcArchiveType class where the header sizes are stored. The type is then chosen depending on the magic string. The decoder is working but I am not sure this is the best solution. Tell me if there are problems or if you think it should be done with another way.

rr- commented 8 years ago

Thank you for your work. Looks good to me. Just a few stylistic requests:

please squash 32a4749 to 82b3288
please extract the change to .gitignore to a separate commit
I think the comment about u4 is unnecessary

consider keeping the header initialization lists in single lines like this:

{
  {"PackFile\x20\x20\x20\x20"_b, {16, 8}},
  {"BURIKO ARC20"_b, {96, 24}},
}

ghost commented 8 years ago

Thanks, I followed your requests. I also merged arc_unpacker/master into my branch to resolve conflicts on the gamelist. Tell me if everything is ok.

rr- commented 8 years ago

Merged, thanks :+1: