voorhoede / head-start

Base setup on top of headless services to help you quickly start a new website
ISC License
3 stars 0 forks source link

137-consent-prompt-for-video-embed-block #138

Closed luukbrauckmann closed 2 weeks ago

luukbrauckmann commented 2 months ago

Changes

Associated issue

Resolves #137

How to test

  1. Open preview link
  2. Scroll down to the Video
  3. Click on the video
  4. There should be an overlay popping up asking for permission
  5. Click the allow button.
  6. Video should start.
  7. Check if this permission is added in the local storage.

Checklist

cloudflare-pages[bot] commented 2 months ago

Deploying head-start with  Cloudflare Pages  Cloudflare Pages

Latest commit: cc2638d
Status: ✅  Deploy successful!
Preview URL: https://bfbf6b0f.head-start.pages.dev
Branch Preview URL: https://137-consent-prompt-for-video.head-start.pages.dev

View logs

luukbrauckmann commented 2 months ago

I could pretty easily copy all the code from the nododos project, because it's pretty generic.

luukbrauckmann commented 2 months ago

Readme already contained an item about the consent alert

jbmoelker commented 1 month ago

👏👏. We should do the same for the Embed Block, but probably in a new PR :)

jbmoelker commented 2 weeks ago

👏👏. We should do the same for the Embed Block, but probably in a new PR :)

See #157