search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
29 stars 27 forks source link

License type GPL-3.0-or-later throws warning #101

Closed mmarseglia closed 6 years ago

mmarseglia commented 6 years ago

Using metadata-json-lint (2.1.0)

Set the following in metadata.json:

  "license": "GPL-3.0-or-later",

Run tests and get this warning message:

(WARN) license: License identifier GPL-3.0-or-later is not in the SPDX list: http://spdx.org/licenses/
Warnings found in metadata.json

The expected behavior is no warnings and the test to pass. The license is valid according to https://spdx.org/licenses/.

rnelson0 commented 6 years ago

This appears to be related to https://github.com/domcleal/spdx-licenses/issues/1, @domcleal can you verify?

domcleal commented 6 years ago

It was just an outdated licence list, as the new -or-later IDs came in with SPDX 3.0. The gem was still on 2.4, so I've pushed a new version with the updated list. It should be fixed now if you update to spdx-licences-1.2.0 :slightly_smiling_face:

(The linked issue is for more complex combinations of multiple licences, which is rare in practice, at least for Puppet modules.)

domcleal commented 6 years ago

Please re-open if the gem update doesn't fix the issue for you.