search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
29 stars 27 forks source link

"dependencies" error #11

Closed otheus closed 9 years ago

otheus commented 9 years ago

The dependencies code needs some "relaxing". Even --no-strict-dependency had NO EFFECT on these.

{
 "dependencies": []
}

Should be fine, indicating no dependencies known at present. But it doesn't work. Similarly, only the name attribute of an entry should be required. The version information should be optional. 

     "issues_url": "",
     "dependencies": [
        { "name": "puppetlabs/stdlib" }
     ]
    }

Similarly, if the "version_requirement" tag is specified, its contents could/might be empty.
  "issues_url": "",
  "dependencies": [
    { "name": "puppetlabs/stdlib", "version_requirement": "" }
  ]
}

also doesn't work.

Work-around: add a "0" to the version_requirement

nibalizer commented 9 years ago

@electrical whatcha think?

nibalizer commented 9 years ago

So I've gone ahead and reverted #9 and released 0.0.6 to rubygems. Hopefully that will fix things. I think the feature is cool but there are a number of problems that came out of it which weren't getting fixed.