search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
31 stars 25 forks source link

Require Ruby 2.1 and drop post_install_message #112

Closed ekohl closed 4 years ago

ekohl commented 4 years ago

Puppet 4 is EOL so there's no real reason to keep showing this message. Nobody should be using Puppet <= 4.8.x anymore.

By keeping Ruby 2.1 support, it is still possible to use Puppet 4.9 and newer.

ghoneycutt commented 4 years ago

Puppet 6 uses ruby 2.5, so why would we care about 2.6 and 2.7 other than to give us a heads up that changes are coming? Suggest we keep 2.6 and 2.7 those though allow them to fail and deploy on 2.5.

ekohl commented 4 years ago

I always use Ruby 2.7 in my dev setups. It's important to be future proof. I think having tests and allowing them to fail is utterly useless. Most people only check if Travis is green from Github and that's it. All our gems should be 2.7 compatible and Puppet themselves also made a push for it recently. It wouldn't surprise me if Puppet 7 will ship with it.

ghoneycutt commented 4 years ago

I use the same ruby that puppet ships with. Allowing tests to fail shows you that future versions of ruby might start failing so the problems can be addressed before you start supporting that version.

ekohl commented 4 years ago

But the tests are passing now so why would we allow any regressions?

DavidS commented 4 years ago

:shipit:

puppet7 will release with ruby 2.7 tomorrow.