For the license: missing a file and license headers in source files

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files

Apache License 2.0

29 stars 27 forks source link

For the license: missing a file and license headers in source files #115

Closed lelutin closed 3 years ago

lelutin commented 3 years ago

Hello,

While scrutinizing this project for creating a package for debian with it, I noticed some details that seem to be missing according to the license that you've chosen for the code:

There needs to be a NOTICE file at the top level
Each source code file should have a header comment mentioning the license and a copyright attribution

You can find more details about those two points in the following URL: https://infra.apache.org/apply-license.html

alexjfisher commented 3 years ago

Those instructions seem to be specific to the Apache organisation applying the Apache licence to their products.

lelutin commented 3 years ago

hmm .. you're right. I looked up in the license text and the presence of the NOTICE file is optional (but if present needs to be kept around).

I'm sorry for the noise then. I'll fix my notes about this license to stop bothering ppl :\

alexjfisher commented 3 years ago

No worries. We're actually very keen to have closer relationships with packagers. Stop by #voxpupuli on Freenode IRC if you want to introduce yourself or have any questions we can help with.