search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
29 stars 27 forks source link

proprietary license identifier #12

Closed dsbaars closed 9 years ago

dsbaars commented 9 years ago

The spdx license list only contains open-source licenses. Other json configs, like composer.json and package.json allow the "proprietary" license identifier for closed-source projects. I hope this can be allowed here as well.

https://getcomposer.org/doc/04-schema.md#license

nibalizer commented 9 years ago

Interesting. @ryanycoleman reccomended the spdx library because it is what the forge uses for validation. We could add code to try validating against spdx, the try validating against proprietary, then fail.

domcleal commented 9 years ago

I guess the Forge isn't ever going to accept 'proprietary' as a licence string, since they wouldn't be able to redistribute the code, but @nibalizer's suggestion sounds like a good idea - allow it as a special string.

dsbaars commented 9 years ago

I really would like to be able to validate my (or my companies) proprietary puppet-modules metadata.json without the need for "--no-strict-license", not all modules go the the forge ;)

I think @nibalizer's suggestion is the way to go here.

jantman commented 9 years ago

I agree... my company uses "Proprietary" to identify modules which we haven't open sourced (this is a management approval process for us). I'd still like to be able to keep these modules release-ready...

Also, in the larger picture, we know there are many companies using Puppet that can't open-source their internal modules. We shouldn't discourage them from using best-practice community module development methods...

igalic commented 9 years ago

:+1:

tuxinaut commented 9 years ago

:+1:

igalic commented 9 years ago

anyone care to provide a patch here ;)

dsbaars commented 9 years ago

Sure :)

dsbaars commented 9 years ago

My pull request is merged (thanks!) and solves the issue so i'll close it.