Open ekohl opened 1 year ago
Base: 50.23% // Head: 50.47% // Increases project coverage by +0.23%
:tada:
Coverage data is based on head (
e65068d
) compared to base (e089948
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The test now fails with:
$ be rake -T
rake aborted!
NameError: uninitialized constant MetadataJsonLint
MetadataJsonLint.options.strict_license = false
^^^^^^^^^^^^^^^^
/home/ekohl/dev/metadata-json-lint/tests/rake_global_options/Rakefile:3:in `<top (required)>'
/home/ekohl/.gem/ruby/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/cli/exec.rb:58:in `load'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/cli/exec.rb:58:in `kernel_load'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/cli/exec.rb:23:in `run'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/cli.rb:486:in `exec'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/cli.rb:31:in `dispatch'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/cli.rb:25:in `start'
/usr/share/gems/gems/bundler-2.3.26/libexec/bundle:48:in `block in <top (required)>'
/usr/share/gems/gems/bundler-2.3.26/lib/bundler/friendly_errors.rb:120:in `with_friendly_errors'
/usr/share/gems/gems/bundler-2.3.26/libexec/bundle:36:in `<top (required)>'
/home/ekohl/bin/bundle:23:in `load'
/home/ekohl/bin/bundle:23:in `<main>'
(See full trace by running task with --trace)
So I guess this is incompatible. Perhaps I should utilize autoload like I did in https://github.com/voxpupuli/puppet-syntax/pull/134 instead.
https://github.com/voxpupuli/metadata-json-lint/pull/124 may be a better idea.
It should not be required to load the whole library just to define the rake task. This prevents pulling in many libraries when a user runs rake -T or an unrelated rake task.