Remove SemanticPuppet compatibility loading

[ekohl]

In d0229854172601aae1ccde6d10433fa1bcb24a1e the minimum Puppet version was raised to 4.10.0 while the vendored Semantic was removed in Puppet 4.6. Ever since it's a real gem dependency which Puppet itself pulls in like a any other gem. This means it can always be loaded directly. This avoids the whole Puppet dependency loading, which speeds things up.

[codecov[bot]]

Codecov Report

Base: 50.23% // Head: 44.91% // Decreases project coverage by -5.32% :warning:

Coverage data is based on head (6a27319) compared to base (e089948). Patch coverage: 50.00% of modified lines in pull request are covered.

:exclamation: Current head 6a27319 differs from pull request most recent head eddae20. Consider uploading reports for the commit eddae20 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #124 +/- ## ========================================== - Coverage 50.23% 44.91% -5.32% ========================================== Files 5 4 -1 Lines 211 187 -24 ========================================== - Hits 106 84 -22 + Misses 105 103 -2 ``` | [Impacted Files](https://codecov.io/gh/voxpupuli/metadata-json-lint/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli) | Coverage Δ | | |---|---|---| | [lib/metadata\_json\_lint.rb](https://codecov.io/gh/voxpupuli/metadata-json-lint/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL21ldGFkYXRhX2pzb25fbGludC5yYg==) | `38.52% <50.00%> (-0.82%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[ekohl]

While reading this I'm leaning to making SemanticPuppet a hard requirement since it doesn't have any dependencies anyway. That simplifies the code and makes the output consistent, regardless of environment. However, that's for another day.

[ekohl]

Upon further reading: the min version is the version that's EOL. That should actually be raised to Puppet 6 then, and soon to Puppet 7.

[bastelfreak]

I implemented your suggestion and made semanticpuppet a hard dep: https://github.com/voxpupuli/metadata-json-lint/pull/136