Do we need to conditionally load semantic_puppet anymore?

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files

Apache License 2.0

29 stars 27 forks source link

Do we need to conditionally load semantic_puppet anymore? #141

Open binford2k opened 2 weeks ago

binford2k commented 2 weeks ago

Do we need this reimplementation? https://github.com/voxpupuli/metadata-json-lint/commit/923f567c6c3a682a2a20be378c4d6a220290d5c3

bastelfreak commented 2 weeks ago

I don't see a reason to keep it. Do you want to revert the old commit?

ekohl commented 2 weeks ago

I don't see why. The commit you refer to comes from a time when Puppet had vendored SemanticPuppet and you could only load one or the other. The vendored implementation has been removed and it's a proper gem now. I thought it was Puppet 4.6, but I see https://github.com/puppetlabs/puppet/commit/429b8bd297ae5c72635fe8e320844221da28d741 was only in 6.0.0. Still, that's new enough.