Ensure options is initialised when the rake task calls 'parse' + rake tests

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files

Apache License 2.0

29 stars 27 forks source link

Ensure options is initialised when the rake task calls 'parse' + rake tests #16

Closed domcleal closed 9 years ago

domcleal commented 9 years ago

Fixes #15

I can drop the changes to tests and submit just the first commit if you prefer. Unfortunately, the tests still don't pick up the error in #15 because both the expected failure and the stack trace cause an exit code of 1. Ideas welcome.. either changing the exit code or interpreting the output perhaps in the tests?

nibalizer commented 9 years ago

Oh shit I've just been sitting on this. Sorry!

domcleal commented 9 years ago

No problem! If you'd like to enable Travis CI on the repo then it should run the tests if I then update the branch.

nibalizer commented 9 years ago

I may have even turned on travis!