Closed 3flex closed 8 years ago
wow, this looks really good. Always cool to see such a detailed PR description, thanks for the work! I've to talk a look tomorrow when I'm really awake again. Please ping any of us in #voxpupuli on freenode if we don't do any progress here in the next days (means: I will probably forget that I want to review this in a few hours :( )
also we should try to modulesync this, even if it is a gem
I've corrected my "note to self" comments and rebased, so this is good for a review.
Looks good to me!
@domcleal rubocop's happy now, and I've versioned the semantic_puppet gem to >= 0.1.2 < 1.0.0
Much better, one style comment inline about the global-ish variable. Unfortunately I'm not a committer, but otherwise it works and looks good to me too.
Thanks for the feedback! I hope this is OK now :)
A hopefully improved version of #9. Closes #24.
Changes compared to #9:
"version_requirement": ""
) is treated as an error by semantic_puppet, so this continues to throw an error. But"dependencies": []
will not throw an error, and{ "name": "puppetlabs/stdlib" }
will be treated as an open ended dependency.Issues with this PR:
If this holds true, there should be low risk of this code breaking due to changes in that gem, as it relies only on the version range code which should stay "relatively stable".