voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
29 stars 27 forks source link

Add dependency version checking #25

Closed 3flex closed 8 years ago

3flex commented 8 years ago

A hopefully improved version of #9. Closes #24.

Changes compared to #9:

Issues with this PR:

Note that this is a 0 release version, and things can change. Expect that the version and version range code to stay relatively stable, but the module dependency code is expected to change.

If this holds true, there should be low risk of this code breaking due to changes in that gem, as it relies only on the version range code which should stay "relatively stable".

bastelfreak commented 8 years ago

wow, this looks really good. Always cool to see such a detailed PR description, thanks for the work! I've to talk a look tomorrow when I'm really awake again. Please ping any of us in #voxpupuli on freenode if we don't do any progress here in the next days (means: I will probably forget that I want to review this in a few hours :( )

bastelfreak commented 8 years ago

also we should try to modulesync this, even if it is a gem

3flex commented 8 years ago

I've corrected my "note to self" comments and rebased, so this is good for a review.

electrical commented 8 years ago

Looks good to me!

3flex commented 8 years ago

@domcleal rubocop's happy now, and I've versioned the semantic_puppet gem to >= 0.1.2 < 1.0.0

domcleal commented 8 years ago

Much better, one style comment inline about the global-ish variable. Unfortunately I'm not a committer, but otherwise it works and looks good to me too.

3flex commented 8 years ago

Thanks for the feedback! I hope this is OK now :)