Rubocop tweaks - Githubissues

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files

Apache License 2.0

29 stars 27 forks source link

Rubocop tweaks #29

Closed 3flex closed 7 years ago

3flex commented 8 years ago

Disable the Metrics cops permanently - they're not useful
Remove a couple of Style cops from the configuration that no longer flag errors

bastelfreak commented 8 years ago

Hi @3flex, what do you think about migrating the config to the one we use in our modules?

3flex commented 8 years ago

Could do. My only issue with that config file is all the cops that are marked explicitly enabled, when the upstream default configuration already enables them. It bloats the config unnecessarily IMHO. I prefer minimal configs.

I'm happy to go through that file and pare it down first? But if you want to use that file here, might as well. It makes sense to keep it consistent between projects.

jyaworski commented 8 years ago

@3flex we're verbose in that config for consistency's sake. We'd rather specify explicitly rather than assume upstream defaults which can (and do) change over time.

3flex commented 8 years ago

I'll update this to use modulesync_config's configuration.

Does this gem support Ruby 1.8? It says it does in the current rubocop config, but modulesync_config's rubocop configuration enables support for Style/HashSyntax cop which enforces Ruby 1.9 style hashes.

jyaworski commented 8 years ago

@3flex we do not support 1.8 on any of our projects, officially. If anything happens to work on 1.8, that's cool.