Open jhoblitt opened 7 years ago
@jhoblitt Can you provide the metadata.json so we can add a sample test for this?
Currently open dependencies only fail on --strict_dependencies
. Likewise, license warnings only raise to an error when --strict-licenses
is used. Adding an || options[:fail_on_warnings]
will certainly raise these warnings to errors. However, it also is essentially a backwards incompatible change as it changes the current default results, even if it doesn't change the default settings being used.
This will need some discussion. I see a few options:
fail-on-warnings
is enabled. Backwards incompatible@rnelson0 the metadata.json
with the warnings is https://github.com/jenkinsci/puppet-jenkins/blob/beaa841665e8cb265d3a8a285270028844c76922/metadata.json
I was a bit surprised that it had warnings that weren't bubbling up as fatal and obviously didn't expect that --fail-on-warnings
doesn't actually make all warnings fatal. I suppose we could just add the strict_dependencies
flag to puppetlabs_spec_helper
, which would solve this for most users, but I feel that the semantics of --fail-on-warnings
should be fixed with a major version bump.
If providing the fail-on-warnings option i would really expect to fail on all warnings.
@jhoblitt can you see if #78 fixes this issue as well as #76