search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
30 stars 27 forks source link

Don't log license ID warning with --no-strict-license #71

Closed domcleal closed 7 years ago

domcleal commented 7 years ago

Prior to a4bc76e, disabling strict-license would log a warning but not exit with a failure, but now logging the warning will exit with a failure status unless fail-on-warnings is also disabled.

This change downgrades license ID failures to warnings all of the time (since it's a recommendation in the docs anyway) and disables them entirely when strict-license is disabled, which better reflects what the flag is useful for - skipping the check.

Now disabling strict-license will not cause a failure exit status and the default behaviour is still to exit with a failure because of the warning.

Fixes #69

cyberious commented 7 years ago

Thanks @domcleal I have had to wrap this for a while to ensure we do it with a hack of clearing the lint task and replacing with a shell to the cli version with --no-strict-license