search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
30 stars 27 forks source link

Add logic to allow for Puppet 5.0.0 compatibility #82

Closed dhollinger closed 7 years ago

dhollinger commented 7 years ago

metadata-json-lint (naturally) isn't aware of the "vendored" version of semantic_puppet found in Puppet 5.0.0. As such, the gem requires the "external" version of semantic_puppet to even function and this means that metadata-json-lint is not compatible with Puppet 5.0.0

A patch is in the works for Puppet 5.0.x that will allow the vendored and external versions of semantic_puppet to coexist, but until then metadata-json-lint is only compatible with Puppet 4.x

dhollinger commented 7 years ago

Added logic to require and use the puppet gem's vendored semantic_puppet if Puppet.version returns "5.0.0". This is to allow compatibility with Puppet 5.0.0.

Feedback needed!

bmjen commented 7 years ago

👍