search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
29 stars 27 forks source link

Make SemanticPuppet completely optional and remove dependency on Puppet #86

Closed scotje closed 6 years ago

scotje commented 6 years ago

This commit changes the two validations that currently use SemanticPuppet to only use that library if it is already available on the load path. If not, it falls back to less robust built-in alternatives that should still be good enough for 99% of use cases. This should eliminate any depdendency headaches around various versions of Puppet and SemanticPuppet.

scotje commented 6 years ago

I can squash that fixup commit if you want, but maybe we want a new post-install message?

rnelson0 commented 6 years ago

While it seems like there's no actual need for Semantic Puppet with <=4.8.0 now, it would probably still be helpful and maybe more accurate, so my vote is to keep a post install message and just modify it to say it is suggested.

DavidS commented 6 years ago

The message could recommend running linting with puppet5 to get best results. There should be no other differences, right?

scotje commented 6 years ago

@rnelson0 @DavidS added a new post-install message

rnelson0 commented 6 years ago

@scotje The new message is ace. Thanks!

scotje commented 6 years ago

Thanks everyone!