search

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files
Apache License 2.0
30 stars 27 forks source link

Clean leading spaces from post_install_message #89

Closed DavidS closed 7 years ago

DavidS commented 7 years ago

This will improve rendering when installing the gem.

rnelson0 commented 7 years ago

I think that would turn

   ----------------------------------------------------------
       For the most accurate results, the semantic_puppet
       gem should be included within your Gemfile if you
       use Puppet <= 4.8.x
   ----------------------------------------------------------

into

----------------------------------------------------------
For the most accurate results, the semantic_puppet
gem should be included within your Gemfile if you
use Puppet <= 4.8.x
----------------------------------------------------------

That's not wrong but I think the indent is on purpose. Perhaps just trim the 2 leading spaces and preserve the indent, or trim the extra hyphens in addition to leading whitespace? I don't have strong feelings either way, though.

DavidS commented 7 years ago

You are quite right. Here's a fix for that.

I'm looking forward to the squiggly heredoc in ruby 2.3