Fail on empty range - Githubissues

voxpupuli / metadata-json-lint

Tool to check the validity of Puppet metadata.json files

Apache License 2.0

30 stars 27 forks source link

Closed pegasd closed 7 years ago

pegasd commented 7 years ago

Fail with a descriptive error when version_requirement is in illegal format or matches an empty range.

pegasd commented 7 years ago

Is testing on Ruby 2.0.0 still applicable? Seems like bundler has issues installing public_suffix under 2.0.0.
I ended up squashing my test case for the code I wrote because we're not testing with a semantic_puppet gem enabled. Should we?

rnelson0 commented 7 years ago

@bastelfreak Do we have a workaround for public_suffix on ruby 2.0.0, or is it time to look into dropping that from tests and supported matrix?

ekohl commented 7 years ago

@rnelson0 pin it in the Gemfile?

pegasd commented 7 years ago

Anything I can do to progress this?

ekohl commented 7 years ago

rnelson0 commented 7 years ago

@pegasd Can you rebase and push so it does a fresh build?

pegasd commented 7 years ago

Doesn't seem like I did this right )-

ekohl commented 7 years ago

That looks like a cherry pick rather than a rebase but we can fix that on merge.

rnelson0 commented 7 years ago

Tests pass so you did something right :)

rnelson0 commented 7 years ago

Hooray, first time using the squash merge and I got it right, too! Thanks @pegasd!