Use npm view package version, fix ensure=>latest bug

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages

https://forge.puppet.com/puppet/nodejs

Apache License 2.0

113 stars 247 forks source link

Closed joelgarboden closed 8 years ago

joelgarboden commented 8 years ago

Tested with tar, using npm versions 2.14.15 and 3.5.3:

This method doesn't work with npm 1.4.29, as npm view $PACKAGE version returns a deprecation warning about the npm version.

Thanks to @nibalizer for the npm view version pointer

igalic commented 8 years ago

Error: The Style/TrailingComma cop no longer exists. Please use Style/TrailingCommaInLiteral and/or Style/TrailingCommaInArguments instead.

we need a modulesync here

juniorsysadmin commented 8 years ago

Modulesync is being done in #200 , which should fix the rubocop stuff

jyaworski commented 8 years ago

Yes; could you rebase/squash?

joelgarboden commented 8 years ago

@jyaworski Rebase and squashed

jyaworski commented 8 years ago

Looks good.