search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

ensure apt-get update is executed before installing packages #201

Closed saz closed 8 years ago

saz commented 8 years ago

If you're using the nodesource repo, nodejs will be installed before apt-get update is run. This will result in the wrong version of nodejs.

bastelfreak commented 8 years ago

:+1:

juniorsysadmin commented 8 years ago

Doesn't this depend on the update frequency hash? https://github.com/puppetlabs/puppetlabs-apt#class-apt

saz commented 8 years ago

The mentioned frequency is only for configuring a run of apt-get update on each run (always), daily or weekly. This does not ensure, that apt-get update is executed, if a new source is added. This might happen by coincidence. And I don't see a reason to run an update with every puppet run. But even with the frequency set to always the module might install the wrong nodejs version, which might be fixed on the next run.

Via Boxer senden

Am 04.02.2016 12:24 nachm. schrieb Ben S notifications@github.com:

Doesn't this depend on the update frequency hash? https://github.com/puppetlabs/puppetlabs-apt#class-apt

— Reply to this email directly or view it on GitHub.

saz commented 8 years ago

Is there any roadmap for a new release? I'm able to stick with the current version from github, but don't want to miss the new release to change it back to a forge version.

saz commented 8 years ago

This PR does also resolve #171