Update validation for EL 6.

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages

https://forge.puppet.com/puppet/nodejs

Apache License 2.0

113 stars 247 forks source link

Closed loopiv closed 8 years ago

loopiv commented 8 years ago

Nodesource now supports branches 4.x and 5.x for EL6. Updated validation of $repo_url_suffix to allow these suffixes.

loopiv commented 8 years ago

The failing CI checks are from upstream and not from the PR.

jyaworski commented 8 years ago

@bastelfreak I think this needs another modulesync.

jyaworski commented 8 years ago

Hi @loopiv. Please rebase against the current master.

loopiv commented 8 years ago

Just rebased.

bastelfreak commented 8 years ago

@loopiv could you take a look at the failed test? That one is related to your change?

loopiv commented 8 years ago

Sorry, should have looked at the tests earlier. Updated the spec test and things seems OK now. If it looks good on your end, should I rebase/squash?

bastelfreak commented 8 years ago

yes, please squash.

bastelfreak commented 8 years ago

thx for the contribution!

loopiv commented 8 years ago

Sure thing. My first PR! Thanks a bunch for the module.