voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Prepare for release 2.0.0 #224

Closed bastelfreak closed 8 years ago

bastelfreak commented 8 years ago

I started with the changelog. I'm not very familiar with nodejs, could someone please take a look if I missed anything? I didn't find anything that looks like a major change, so I propose 1.4.0 as the next version.

bjoernhaeuser commented 8 years ago

When using current master (818f81e0dfdf9ebf251600c3bb9513b336b34206), I get these messages:

# puppet agent --test
Notice: Ignoring --listen on onetime run
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not autoload puppet/provider/package/npm: /var/lib/puppet/lib/puppet/provider/package/npm.rb:3: syntax error, unexpected ':', expecting $end
...package).provide :npm, parent: Puppet::Provider::Package do
                              ^
Error: Could not retrieve local facts: Could not autoload puppet/provider/package/npm: /var/lib/puppet/lib/puppet/provider/package/npm.rb:3: syntax error, unexpected ':', expecting $end
...package).provide :npm, parent: Puppet::Provider::Package do
                              ^
Error: Failed to apply catalog: Could not retrieve local facts: Could not autoload puppet/provider/package/npm: /var/lib/puppet/lib/puppet/provider/package/npm.rb:3: syntax error, unexpected ':', expecting $end
...package).provide :npm, parent: Puppet::Provider::Package do
                              ^

Any idea where this is coming from?

bastelfreak commented 8 years ago

Are you on ruby1.8? We don't support that anymore.

juniorsysadmin commented 8 years ago

Looks alright to me

jyaworski commented 8 years ago

Rubocop.