voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Actually remove gpg_key dependency. #253

Closed MG2R closed 7 years ago

MG2R commented 7 years ago

The changelog for release 1.3.0 states that the gpg_key dependency is removed. This should be reflected in metadata.json.

MG2R commented 7 years ago

Hm. Build failure seems to be on some unrelated line. Unsure what to do here.

lib/puppet/provider/package/npm.rb:3:1: C: Metrics/BlockLength: Block has too many lines. [61/25] 

Puppet::Type.type(:package).provide :npm, parent: Puppet::Provider::Package do ...

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
bastelfreak commented 7 years ago

@MG2R there is an issue with the used email addr in your commit, it isn't associated with your github account. The rubocop should be disabled, there may be a typo in it, I will check.

MG2R commented 7 years ago

Thanks for the heads-up. Amended the commit to fix the author e-mail.

bastelfreak commented 7 years ago

thanks!