voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Dependency cycle on ubuntu 14.04 #281

Closed pscadiz closed 7 years ago

pscadiz commented 7 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

class { '::nodejs':
}

What are you seeing

Puppet fails to run with a dependency cycle

What behaviour did you expect instead

Node to be installed

Output log

Error: Could not apply complete catalog: Found 1 dependency cycle
(Anchor[::nodejs::begin] => Class[Nodejs::Repo::Nodesource] => Class[Nodejs::Repo::Nodesource::Apt] => Apt::Source[nodesource] => Apt::Setting[list-nodesource] => File[/etc/apt/sources.list.d/nodesource.list] => Class[Apt::Update] => Exec[apt_update] => Class[Apt::Update] => Stage[setup] => Stage[main] => Class[Nodejs::Repo::Nodesource])

Any additional information you'd like to impart

Running puppet on a docker container based on atlassian/bamboo-base-agent. Also updated puppetlabs-apt to tag 2.3.0

ghost commented 7 years ago

:+1: Confirmed on :

ghost commented 7 years ago

hey! Any update or ETA on this?

bastelfreak commented 7 years ago

Hi @pscadiz and @zehzehpeh. Thanks for reporting this error. Is one of you able to provide a patch for this?

ghost commented 7 years ago

@bastelfreak unfortunately I am not able to invest much time in this at the moment. However, I'd be more than happy to test any patch you send my way.

ffrank commented 7 years ago

I'd love to see this fixed, but please note that Puppet 3.x is not supported by this module anymore. The issue appears to not be reproducible w/ Puppet 4.x.

Is a Puppet upgrade an option for you at all?

ghost commented 7 years ago

Puppet 3.x is not supported by this module anymore.

Fair enough.

Is a Puppet upgrade an option for you at all?

I am currently trying to confirm the issue is indeed because of Puppet 3.x by testing the same role in Puppet 4.x. If this is confirmed, the PR should be rejected. I will update this ticket and the PR accordingly.

ghost commented 7 years ago

As commented in the PR, it seems the problem is indeed related to Puppet 3 vs 4.

ffrank commented 7 years ago

Thanks for the feedback.

Closing this as WONTFIX.