search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

npmrc can take k,v #292

Closed Poil closed 7 years ago

Poil commented 7 years ago

Fix for #290

Add a npmrc_config hash to allow the possibility to add some configuration to /root/.npmrc

ffrank commented 7 years ago

Thanks for this patch! It looks good in general.

Weird, the failing test seems to be a linter error on some lines you didn't touch. New linter settings? Paging @juniorsysadmin and @bastelfreak.

@Poil do you think you could add some tests for your new feature, as well as some documentation?

bastelfreak commented 7 years ago

@ffrank yep! got introduced in the last puppet-lint update.

@Poil I merged https://github.com/voxpupuli/puppet-nodejs/pull/293, can you please rebase this PR?

Poil commented 7 years ago

Rebased

ffrank commented 7 years ago

Great, and thanks for the tests!

I'm merging this as is. If you could add some documentation, please feel super welcome to make another PR :)

Thank you for the contribution.