search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Add the ability to manage dependent packages else where. #298

Closed kwolf-zz closed 6 years ago

kwolf-zz commented 7 years ago

We already manage one of the packages (ca-certificates) elsewhere. This adds the ability to manage dependent packages outside of the nodejs module to avoid duplicate package definitions.

juniorsysadmin commented 7 years ago

@kwolf Would prefer that this uses manage_dependencies as the parameter for semi-consistent variable naming reasons

kwolf-zz commented 7 years ago

I thought about that but I wanted it to be more clear that it was package dependencies. I am still happy to change it if you want me too.

juniorsysadmin commented 7 years ago

Puppet will pull in package dependencies via yum, apt etc so leaving package in the name might lead to confusion. manage_repo_dependencies is even more explicit, if you were after more naming suggestions...

juniorsysadmin commented 7 years ago

@kwolf Status of this PR?

juniorsysadmin commented 6 years ago

Kinda superseded by #348 . Which might make it more difficult to solve your problem. Or not.