search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Update acceptance tests, add EPEL test case for RedHat acceptance tests #308

Closed wyardley closed 7 years ago

wyardley commented 7 years ago

This does a few things:

  1. Updates spec_helper_acceptance to use puppet_install_helper
  2. Updates .travis.yml / .sync.yml to run acceptance tests in CI (CentOS 7 and Ubuntu 14)
  3. Verifies some extra stuff, including the package source. This will fail as of now, because of the problem mentioned in #307 / https://bugzilla.redhat.com/show_bug.cgi?id=1481008

There are still some issues that running these tests exposes. It seems like Ubuntu 16.04 installs the Ubuntu version of nodejs vs. the nodesource one; I'm not trying to fix that one (or test for it) here.

wyardley commented 7 years ago

ps - the failed test on CentOS 7 is expected (for now).

wyardley commented 7 years ago

@ekohl @bastelfreak - How does that look now? I think I've addressed most of your (very helpful) feedback. The tests now pass except for the expected failure.

wyardley commented 7 years ago

In most recent push, I set the failing part as pending, we could then take the pending line out when CentOS 7.4 comes out?

wyardley commented 7 years ago

@ekohl: how's it look now?

wyardley commented 7 years ago

Updated to use module_install_helper