Closed wyardley closed 5 years ago
Also similarly: #258 Not so sure if the module should / can enforce the exact source, though it would be cool if there were just an enum to select the source, and the module would ensure that the package came only from that source.
Setting the value of nodejs::repo_pin
so that it presumably has a higher priority than base might be what you're after.
@juniorsysadmin I'm mostly trying to figure out what the desired behavior is [i.e., how the module should behave]... then someone can figure out how it should be implemented.
@wyardley There might be a bit of confusion with regard to package versioning and repository priorities. I don't think it was the intention to have the NodeSource repo URL directly control the version that gets installed rather than nodejs_package_ensure
. I have added #322 to make the docs clearer.
Yeah, the thing I was trying to get clarity about the expected behavior for was having the acceptance test check the package source. However, it seems like we should probably just not have the acceptance test check the package's source if the goal is not to necessarily have a predictable outcome purely based on what repos are enabled.
I can submit a PR to that effect.
Closing due to age, feel free to re-open.
It seems like Ubuntu 16.04 is configuring the nodesource repo:
https://github.com/voxpupuli/puppet-nodejs/blob/master/manifests/params.pp#L83-L86
However, the installed package actually ends up being from the default repo, presumably because it's a different version? I can work on this in #308, but right now, it will fail, because I built in the expectation that the package should come from nodesource. Let's figure out how this should behave, and then we can figure out whether the right fix is adjusting the test or adjusting the module.