search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Apt module missing as a dependency #332

Closed TraGicCode closed 6 years ago

TraGicCode commented 6 years ago

the following module is missing as a dependency in this module and should be fixed.

puppetlabs-apt

alexjfisher commented 6 years ago

See https://github.com/voxpupuli/puppet-virtualbox/issues/43

juniorsysadmin commented 6 years ago

@TraGicCode puppetlabs-apt is a soft dependency: https://puppet.com/docs/puppet/5.3/style_guide.html#dependencies It is mentioned in the README though: https://github.com/voxpupuli/puppet-nodejs/blob/master/README.md#module-dependencies

TraGicCode commented 6 years ago

@juniorsysadmin very strange, my interpretation of a soft dependency was my code doesn’t reference any code from other modules but another modules code is expected to be used to setup certain prequisites. If you want to use that module you can. If not do it your own way.

TraGicCode commented 6 years ago

Looked at the puppet docs got me fixed up. Going to update my definition. Thanks guys!