search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Enhance distro support #342

Closed fnoop closed 6 years ago

fnoop commented 6 years ago

Add explicit Debian 9 (stretch) support, and add support for Ubilinux.

Ubilinux 4 (that supports all variants of the Up boards) is a derivative of Debian 9. However it reports dolcetto as the lsbdistcodename instead of stretch so the nodejs repo fails. This PR adds support for a $nodejs::repo_release parameter that allows the distro code name to be specified rather than blindly taking it from lsbdistcodename.

eg.:

    class { 'nodejs':
        repo_url_suffix => '8.x',
        repo_release    => 'stretch',
        nodejs_package_ensure => latest,
    }
fnoop commented 6 years ago

Note: the failing travis checks appears to be because of missing nodejs-dev package, but the managed nodejs repo doesn't seem to provide this package - headers are included in the main nodejs package by the look of it.

juniorsysadmin commented 6 years ago

@fnoop Are you now able rebase on top of master to fix the merge conflicts? (#343 was merged, which had some of your changes)

juniorsysadmin commented 6 years ago

Have stolen the relevant bits in this change and put them in #349